GHA renovation #3396
GHA renovation #3396
Conversation
* branches (all) * timeout-minutes * checkout version * harmonization across scripts (spacing / wording / labels) * remove chmod for gradlew (unnecessary) Caching tweaks: removed this but I'm unsure: apache/lucene-solr#1910
| - name: Setup Gradle | ||
| uses: gradle/actions/setup-gradle@v4 | ||
| - name: Install ACL | ||
| run: sudo apt-get install acl |
There was a problem hiding this comment.
Do we not need this any more? @HoustonPutman is probably better to look
There was a problem hiding this comment.
in passing tests I trust :-) (which they do)
|
The elaborate caching configuration is not in Lucene, despite that same elaborate caching configuration being committed before the lucene-solr split. Thus Lucene devs removed it. In particular, it was @dweiss in apache/lucene#13110 I'm going to further improve this PR to use the nice |
|
@madrob when you first added that 5 years ago, we weren't using the GHA gradle action or it didn't exist then. It now does with caching built-in. My goal here is to simplify. |
|
The docker build isn't taking any noticeably longer here than the test runs I see in the GHA dashboard for that script. |
* GHA renovation * branches (all) * timeout-minutes * checkout version * harmonization across scripts (spacing / wording / labels) * remove chmod for gradlew (unnecessary) * From Lucene: prepare-for-build * Refactor workflows to use our prepare-for-build
Caching tweaks: removed this but I'm unsure:
apache/lucene-solr#1910 CC @madrob